Skip to content

Change values in .yaml for tests in Django 4.0 #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2021
Merged

Change values in .yaml for tests in Django 4.0 #165

merged 1 commit into from
Dec 21, 2021

Conversation

nickmoreton
Copy link
Contributor

@nickmoreton nickmoreton commented Dec 21, 2021 •
edited
Loading

Description

Tests failed when running against Django 4.0

The .yaml file values needed to be changed to 'strings' but I'm not entirely sure why that works here.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

@nickmoreton nickmoreton changed the title change values in .yaml Change values in .yaml for tests in Django 4.0 Dec 21, 2021
@nickmoreton nickmoreton marked this pull request as ready for review December 21, 2021 17:44
thibaudcolas
thibaudcolas approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nickmoreton! I’m going to merge this right away because it’s great to have our test suite all passing on main, and open a separate issue about whether we should encourage users of this library do the same – or whether we should change our implementation.

@thibaudcolas thibaudcolas merged commit 58bc5ec into main Dec 21, 2021
@thibaudcolas thibaudcolas deleted the django-40-test-errors branch December 21, 2021 20:14
@thibaudcolas thibaudcolas added bug Something isn't working django Related to Django templates capabilities labels Dec 21, 2021
@thibaudcolas thibaudcolas mentioned this pull request Dec 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaudcolas thibaudcolas thibaudcolas approved these changes

Assignees
No one assigned
Labels
bug Something isn't working django Related to Django templates capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickmoreton @thibaudcolas